Skip to content

Update README.MD - "Type: For reference" labels link #5619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 21, 2021
Merged

Update README.MD - "Type: For reference" labels link #5619

merged 4 commits into from
Sep 21, 2021

Conversation

VojtechBartoska
Copy link
Contributor

Summary

Updating a link to issues labeled with "Type: For reference". The old one is not working due to the updates of labels in the past.

Impact

None

Adding first version of PULL_REQUEST_TEMPLATE.md.

The purpose of this template is to improve and simplify writing more accurate Release Notes.
Updating a link to issues labeled with "Type: For reference". The old one is not working due to the updates of labels in the past.
@VojtechBartoska VojtechBartoska added the Type: Documentation Issue pertains to Documentation of Arduino ESP32 label Aug 31, 2021
@pedrominatel
Copy link
Member

@VojtechBartoska please add a new RELEASE NOTES mandatory field.

We can use this new field to improve our release notes for the next release.

@VojtechBartoska
Copy link
Contributor Author

VojtechBartoska commented Sep 1, 2021

@pedrominatel It will overlap a bit with PR "Summary field". Other option is to edit this field manually (if it's not properly filled up by author of PR) and set up some script which will consider that "Release notes" field and build release notes automatically from that. What do you think? Maybe it's too complicated and writing release notes manually will be faster.

Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VojtechBartoska
Copy link
Contributor Author

@me-no-dev can you please merge this to update README?

@me-no-dev me-no-dev merged commit 9f827a6 into espressif:master Sep 21, 2021
@me-no-dev
Copy link
Member

didn't we have this template already?

@VojtechBartoska
Copy link
Contributor Author

Ah, it's the same. No changes there, I didn't pull properly. Changes only on README.

aIecxs pushed a commit to aIecxs/arduino-esp32 that referenced this pull request Oct 24, 2024
* Create PULL_REQUEST_TEMPLATE.md

Adding first version of PULL_REQUEST_TEMPLATE.md.

The purpose of this template is to improve and simplify writing more accurate Release Notes.

* Update PULL_REQUEST_TEMPLATE.md

Fix typo.

* Update README.MD - "Type: For reference" labels link

Updating a link to issues labeled with "Type: For reference". The old one is not working due to the updates of labels in the past.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants